Merged
Conversation
Pliner
approved these changes
Jun 6, 2023
musale
approved these changes
Jun 6, 2023
Kludex
commented
Jun 7, 2023
| - [ ] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!) | ||
| - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. | ||
| - [ ] I've updated the documentation accordingly. | ||
| - [ ] I've added a note on the `docs/release-notes.md` about my changes (changes on documentation or type annotations don't need this). |
Owner
Author
There was a problem hiding this comment.
I'm removing this here since I noticed this will be a problem on future PRs, since we have a script that checks the version on __init__.py against the first version found on the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare: 0.27.0...master
GH release draft: https://github.com/encode/starlette/releases/tag/untagged-19264a765df54797b8e7